Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update APIs, use Promises #8

Open
stuartpb opened this issue Jan 25, 2016 · 2 comments
Open

Update APIs, use Promises #8

stuartpb opened this issue Jan 25, 2016 · 2 comments

Comments

@stuartpb
Copy link
Member

This is the first thing that need to take care of: there's a lot of clumsy, ugly Nodebacks in the current code that can and should be swapped with Promises, as well as other stuff that can be replaced with more modern ES2015 equivalents (Map, fetch, etc).
@stuartpb
Copy link
Member Author

Unfortunately, a full refactor isn't currently possible, due to Chrome apparently not understanding how to GC block-scoped functions. smdh

stuartpb added a commit that referenced this issue Jan 25, 2016
@stuartpb
Roll back block-scoped function declarations
690bfb1 
As mentioned in #8, Chrome can't handle block-scoped functions
due to http://crbug.com/580934
@stuartpb
Copy link
Member Author

Most stuff involving Map has to do with ugly alien mindbenders like whatever we're currently doing to use chrome.storage.local as a backing store for saved domain hints, so that's probably not going to get fixed, in light of #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stuartpb