Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to maintained if-addrs crate #19

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

mon
Copy link
Contributor

@mon mon commented Apr 2, 2024

Pro: mips should work now
Con: The mips pipeline no longer runs because of rust-lang/compiler-team#648

Not really sure of the best action here...

I'll add the link-local stuff in another PR so there's a clear chain of commits.

@mon
Copy link
Contributor Author

mon commented Apr 11, 2024

Thoughts on MIPS solutions:

Any thoughts? Not in a hurry to merge, I just remember it every now and then 😅

@bltavares
Copy link
Owner

Hey there! I'm not ignoring this PR, but my MIPS setup is completely broken, and it's been taking a while to update and fix due to upstream lack pre-compiled libstd now.

I really appreciate the update, and as soon as I have more time, and can actually fix my local setup, I'll be landing this change

@mon
Copy link
Contributor Author

mon commented Apr 18, 2024

Excellent, thanks! Good luck fixing your local setup, I don't envy you...

@bltavares
Copy link
Owner

I've been able to validate the changes on Windows amd64, Linux amd64 and Linux MIPS :)

Thanks for the contribution!

@bltavares bltavares merged commit 580beaa into bltavares:master Apr 27, 2024
9 of 14 checks passed
@mon mon deleted the new-if-addrs branch April 27, 2024 14:13
@mon
Copy link
Contributor Author

mon commented Apr 27, 2024

Excellent news, thanks! How'd you fix your MIPS setup in the end? Just using an older rustc, or did you massage std to compile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants