Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save a hash of the hls.js release #3464

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Jun 13, 2024

This ensures the downloaded hls.js matches exactly and removes a dependency on cdn.jsdelivr.net

It also makes it easier for the nixpkgs version of mediamtx to get the hls.min.js updates, because right now this needs to be done manually

@bouk bouk changed the title Save a hash of the hls.min.js release Save a hash of the hls.js release Jun 13, 2024
This ensures the downloaded hls.js matches exactly and removes a dependency on cdn.jsdelivr.net
@aler9 aler9 merged commit dfa2e81 into bluenviron:main Jun 17, 2024
6 checks passed
@aler9
Copy link
Member

aler9 commented Jun 17, 2024

This has been merged, thanks.

Regarding the NixOS problem, in my opinion it has been fixed in the wrong way, since the proper solution consists into adding go generate to the package building process. Command go generate was introduced in order to run any pre-compilation step by using a single, standard, command. If pre-compilation steps are instead embed into the package and run manually, there's no guarantee that the software will compile correctly in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants