Fix XRPC fetch usage for newly required duplex option #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2023
dholms
approved these changes
Jan 18, 2023
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
…#470) Fix xrpc fetch usage for newly required duplex option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of node v18.13.0 a change to the fetch spec is now reflected in node's fetch implementation. In short, for streaming request bodies the option
duplex: 'half'must explicitly be passed tofetch(). Part of the trickiness here is that this change to the spec is not reflected in docs such as MDN yet, nor in Typescript's lib.dom types.Refs:
Issue as surfaced in node: nodejs/node#46221
Spec discussion: whatwg/fetch#1438
Implementation in node: nodejs/undici#1681
Docs on
duplex: https://fetch.spec.whatwg.org/#ref-for-dom-requestinit-duplexUse node's types for fetch rather than typescript's lib.dom: DefinitelyTyped/DefinitelyTyped#60924