Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic support for specifying create timeout. #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hozn
Copy link

@hozn hozn commented Feb 10, 2022

For me the Vagrant VMs were never building before apparently being timed out by terraform. My golang knowledge is rudimentary, to say the least, but I examined how this was implemented for another provider and got a version that appears to work (respecting the configured timeout values).

Happy to update the docs too, if you're amenable to this PR.

@bmatcuk
Copy link
Owner

bmatcuk commented Feb 14, 2022

Hey @hozn, thanks for the PR! Do you know if the timeouts are coming from terraform, or from vagrant? According to the terraform docs the default timeout should have been 20 minutes whereas I see you defaulted to 2 minutes in your PR. Are you using the timeouts {} directive in your terraform configuration?

@bmatcuk bmatcuk self-requested a review February 14, 2022 20:46
@bmatcuk bmatcuk added the enhancement New feature or request label Feb 14, 2022
@hozn
Copy link
Author

hozn commented Feb 15, 2022

Hmm ... I am using that directive and it seemed to address an issue, but it sounds like I need to investigate further what might have been timing out and whether that was a coincidence!

@bmatcuk
Copy link
Owner

bmatcuk commented Feb 15, 2022

Hmm, ya, I'd like to get to the bottom of the problem to make sure we've got the right solution =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants