Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to the mk macro on final returns in parser.rs #1

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Remove calls to the mk macro on final returns in parser.rs #1

merged 1 commit into from
Sep 24, 2018

Conversation

someguynamedmatt
Copy link
Contributor

@someguynamedmatt someguynamedmatt commented Sep 24, 2018

This urges a discussion:

  • What do the Position attributes do in the Expr structs? They don't have a use currently, but I can't imagine they were thrown in there by Bebbington "just because".

  • The solution proposed is probably more of a band-aid than an actual solution. At least until we can figure out what the start and end (Position) attrs are for.

@jasonwilliams
Copy link
Member

nice one, just checked out and its working.
hmm im not sure either, was it so if there was an error processing an expression it would spit out the line/column number?
Maybe we should remove them if we don't need them for now?

@someguynamedmatt
Copy link
Contributor Author

someguynamedmatt commented Sep 24, 2018

It might be that, but it also might be for more complex blocks. I tried to do a simple

if ( 1 === 1) {
   b = 'cat';
}

and it broke. That could have happened for any number of reasons, but I dunno as of yet.

Removing them might make sense. If we hit the "Oh crap, we need that" point, we can put them back in.

@jasonwilliams jasonwilliams merged commit 152b86c into boa-dev:master Sep 24, 2018
@jasonwilliams
Copy link
Member

Whats your debugging set up at the moment? Are you just printing until it breaks or do you have some debugger up and running?

@someguynamedmatt
Copy link
Contributor Author

println! until I narrow-down the issue. I'm primitive. What's your setup?

@jasonwilliams
Copy link
Member

Same, vscode, been trying to get the debugger up and running, it works well but had an issue which is documented here:
vadimcn/codelldb#127

bors bot pushed a commit that referenced this pull request Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants