Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #3

Merged
merged 6 commits into from
Jul 8, 2023
Merged

Increase test coverage #3

merged 6 commits into from
Jul 8, 2023

Conversation

bobg
Copy link
Owner

@bobg bobg commented Jul 8, 2023

This PR increases test coverage, and fixes one or two bugs that the new tests revealed.

It also removes the field Checker.Interfaces. It was used to control whether the checker looked for parameters whose types were interfaces but could be narrowed (such as io.ReadCloser -> io.Reader). It's now assumed that behavior is always wanted.

It also expands the Readme some.

@bobg bobg changed the title Bobg/test coverage Increase test coverage Jul 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Pull Request Test Coverage Report for Build 5495962276

  • 3 of 10 (30.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+14.0%) to 72.774%

Changes Missing Coverage Covered Lines Changed/Added Lines %
decouple.go 3 10 30.0%
Totals Coverage Status
Change from base Build 4669415880: 14.0%
Covered Lines: 572
Relevant Lines: 786

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires an increase in your module’s major version number.
If the new major version number is 2 or greater,
you must also add or update the version suffix
on the module path defined in your go.mod file.
See the Go Modules Reference for more info.

checking NewCheckerFromPackages
  in results of func(pkgs []*golang.org/x/tools/go/packages.Package) github.com/bobg/decouple.Checker
    old struct field Interfaces was removed from github.com/bobg/decouple.Checker
      Major

@bobg bobg marked this pull request as ready for review July 8, 2023 20:39
@bobg bobg merged commit 011ef0a into main Jul 8, 2023
1 check passed
@bobg bobg deleted the bobg/test-coverage branch July 8, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant