-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSVC 14_0 stdndards and has-include corrections #1017
Conversation
The lexical parser isn't into it.
I need to go with the former preprocessor stuff, or at least try it out first. |
Well the code logic is OK and things are going green but I messed up the GHA logic a bit and a few too many runners are being run. So this will need one more logic fix on the YAML layer. Coming right up, ... |
It does work: Boost.Config is using it for all compilers including vintage msvc: https://github.com/boostorg/config/blob/d483059795f8bf77120ee423d1660532223e5795/include/boost/config/detail/select_stdlib_config.hpp#L18 |
Ahhh good save, John. I tried the line: #if (defined(__has_include) && (__has_include(<stdfloat>))) But the variation should be: #if defined(__has_include)
#if __has_include(<stdfloat>)
#include <stdfloat>
#endif
#endif |
John (@jzmaddock) could we agree on? #if defined(__has_include)
#if __has_include(<stdfloat>)
#include <stdfloat>
#endif
#endif Cc: @mborland |
That is the format that GCC recommends: https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005finclude.html |
Great thank you Matt (@mborland). I will cycle this through, then: #if defined __has_include
# if __has_include (<stdfloat>)
# include <stdfloat>
# endif
#endif |
Matt (@mborland) while we are at it, I used super-rudimentary logic on the YAML-ing. Would you please take a look and see if you can agree to that? Or can we do better? |
It looks good to me. Definitely more compact than making it own config for one compiler. |
Thanks Matt. OK let's let this thing cycle through. It is cycling green even with recent changes in develop to I'm not sure if this is or is not expected. But I'm happy to observe that. |
Single failure on drone to clone. Merging. |
The purpose of this PR is to handle trivial syntax improvements mentioned in #1016.