has_denorm_now #1029
Merged
has_denorm_now #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Matt, this looks good to me! Any reason not to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #1028,
std::numeric_limits<T>::has_denormhas been deprecated in C++23.This PR refactors
get_smallest_valueto no longer usehas_denorm. A new methodhas_denorm_nowis created that checks if denorms are supported at runtime by comparing the output ofboost::math::detail::get_smallest_valuewith that ofboost::math::tools::min_value. Most other instances of the compile time constanthas_denormare replaced by the runtime calculated versionhas_denorm_now.