Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make boost::math::ccmath::fminf and boost::math::ccmath::fminl constexpr #1146

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Make boost::math::ccmath::fminf and boost::math::ccmath::fminl constexpr #1146

merged 1 commit into from
Jun 14, 2024

Conversation

quxflux
Copy link
Contributor

@quxflux quxflux commented Jun 14, 2024

The publicly visible declarations of boost::math::ccmath::fminf and boost::math::ccmath::fminfl are neither marked inline nor constexpr, which causes "multiple definition" linker errors when the boost/math/ccmath/fmin.hpp header gets included in multiple translation units of a binary.

Therefore this PR marks said functions constexpr.

Fixes #1145

Copy link
Member

@mborland mborland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved the CI run. Thanks!

@quxflux quxflux marked this pull request as ready for review June 14, 2024 12:02
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (70cdb37) to head (dff806a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1146      +/-   ##
===========================================
+ Coverage    93.71%   93.76%   +0.05%     
===========================================
  Files          774      772       -2     
  Lines        61271    61251      -20     
===========================================
+ Hits         57422    57434      +12     
+ Misses        3849     3817      -32     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70cdb37...dff806a. Read the comment docs.

@quxflux quxflux closed this Jun 14, 2024
@quxflux quxflux reopened this Jun 14, 2024
@mborland mborland merged commit c5dc6c7 into boostorg:develop Jun 14, 2024
79 checks passed
@quxflux quxflux deleted the quxflux-patch-1 branch June 15, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially missing inline/constexpr specifier in boost/math/ccmath/fmin.hpp
2 participants