Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add randomize_va_space to drone #1149

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Add randomize_va_space to drone #1149

merged 2 commits into from
Jul 3, 2024

Conversation

mborland
Copy link
Member

@mborland mborland commented Jul 2, 2024

No description provided.

@mborland
Copy link
Member Author

mborland commented Jul 3, 2024

@sdarwin both sudo sysctl vm.mmap_rnd_bits=28 and 30 give the same memory mapping error. Any other ideas, or does it need to go at an earlier point in the script?

@sdarwin
Copy link
Contributor

sdarwin commented Jul 3, 2024

It should be 28: sudo sysctl vm.mmap_rnd_bits=28 , and inside the if [[ $(uname) == "Linux" ]]; then , however if that is not working, try to use clang 18.1

google/sanitizers#1716

Newer versions of TSan (LLVM 18.1.0 onwards: llvm/llvm-project@0784b1e) will automatically re-exec without ASLR, if the layout is incompatible. Additionally, TSan in LLVM 18.1.0 onwards can support 30 bits of ASLR entropy without disabling ASLR (llvm/llvm-project@7d039ef).

@mborland
Copy link
Member Author

mborland commented Jul 3, 2024

Clang-18 seems to be working fine. Thanks for the help!

@mborland mborland merged commit 5459e14 into develop Jul 3, 2024
75 of 76 checks passed
@mborland mborland deleted the tsan branch July 3, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants