Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubic roots #703

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Cubic roots #703

merged 2 commits into from
Oct 27, 2021

Conversation

NAThompson
Copy link
Collaborator

No description provided.

@NAThompson NAThompson force-pushed the cubic_roots branch 5 times, most recently from 62d79b6 to 04e2510 Compare October 23, 2021 21:42
@NAThompson
Copy link
Collaborator Author

@jzmaddock, @mborland : Could you take a look?

@NAThompson NAThompson force-pushed the cubic_roots branch 3 times, most recently from 1ee5159 to 0903a63 Compare October 24, 2021 17:22
@NAThompson
Copy link
Collaborator Author

@jzmaddock : I can't build the docs anymore; does the CI build the docs? I'm a bit worried about the unicode in the .qbk file.

@NAThompson NAThompson force-pushed the cubic_roots branch 2 times, most recently from 38295d8 to 2836fff Compare October 24, 2021 18:16
@jzmaddock
Copy link
Collaborator

@NAThompson : I've just killed all the CI except the most recent, that batch of pushes had created a huge backlog...

@jzmaddock
Copy link
Collaborator

I can't build the docs anymore; does the CI build the docs? I'm a bit worried about the unicode in the .qbk file.

Yes, the CircleCI job builds the docs.

However, a mark one eyeball over the generated docs is still a good idea. How come you can't build the docs?

@NAThompson
Copy link
Collaborator Author

@NAThompson : I've just killed all the CI except the most recent, that batch of pushes had created a huge backlog...

Bah, my bad. I still contend the default should be to kill the jobs if you force push an update!

(It's the universe that's wrong, not me.)

@NAThompson
Copy link
Collaborator Author

How come you can't build the docs.

$ ../../b2 doc
In file included from ../../boost/math/policies/policy.hpp:11:
../../boost/math/tools/mp.hpp:22:18: warning: variadic templates are a C++11 extension [-Wc++11-extensions]
template<typename... T>

I can't for the life of me convince b2 that it's allowed to use C++11.

@NAThompson
Copy link
Collaborator Author

The failing checks are the known issues in the Bernoulli numbers.

@NAThompson NAThompson merged commit 923ed19 into develop Oct 27, 2021
@NAThompson NAThompson deleted the cubic_roots branch October 27, 2021 03:54
@jzmaddock
Copy link
Collaborator

The failing checks are the known issues in the Bernoulli numbers.

What known issues?

It's just annoying to have failures in CI as it makes it so much harder to evaluate PR's.

@NAThompson
Copy link
Collaborator Author

@jzmaddock : I grepped through the log and found this:

../../../boost/math/special_functions/bernoulli.hpp:74:24: note: in instantiation of function template specialization 'boost::math::bernoulli_b2n<boost::multiprecision::number<boost::multiprecision::backends::cpp_bin_float<50, boost::multiprecision::backends::digit_base_10, void, int, 0, 0>, boost::multiprecision::et_off>, boost::math::policies::policy<boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy, boost::math::policies::default_policy> >' requested here
1305
   return boost::math::bernoulli_b2n<T>(i, policies::policy<>());
1306
                       ^
1307
bernoulli_no_atomic_fail.cpp:14:71: note: in instantiation of function template specialization 'boost::math::bernoulli_b2n<boost::multiprecision::number<boost::multiprecision::backends::cpp_bin_float<50, boost::multiprecision::backends::digit_base_10, void, int, 0, 0>, boost::multiprecision::et_off> >' requested here
1308
   check_result<boost::multiprecision::cpp_bin_float_50>(boost::math::bernoulli_b2n<boost::multiprecision::cpp_bin_float_50>(4));
1309
                                                                      ^
1310
1 error generated.

And . . . its an expected error. So my bad; I need to submit a fixup commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants