Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCC-5 to drone config #758

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Add GCC-5 to drone config #758

merged 1 commit into from
Feb 10, 2022

Conversation

mborland
Copy link
Member

@mborland mborland commented Feb 9, 2022

Based off conversation in boostorg/boost#610 add GCC-5 back to our testing.

@mborland
Copy link
Member Author

mborland commented Feb 9, 2022

@jzmaddock The drone run is clean with GCC-5. Is this a change you want to pursue?

CC: @ckormanyos

@ckormanyos
Copy link
Member

ckormanyos commented Feb 10, 2022

with GCC-5

We never really formalized plans here. But for clarity's sake,...

  • I would like to try for GCC-5 on both Math and Multiprecision for 1.79.
  • In the summer, we can see how things look in CI for runners on 4.8 or 4.9.

If it 4.x (on -std=c++11 only) goes well, we can include these in 1.80 as well. If not, then simply bail on that legacy 4.x support. We might have to change some of the PP logic to go back down to 4. or we might decide to let it go unsuccessfully if the work is not warranted by the gains.

@mborland
Copy link
Member Author

I can merge this in then; GCC-5 didn't encounter any issues on the drone run. GCC-5 was released in April 2015 so if 4.X does not work out of the box I don't think I would sink much time into making it work. Having a less than 7 year old compiler for an 11 year old standard does not seem like a big ask.

@mborland mborland merged commit 5d979d9 into boostorg:develop Feb 10, 2022
@mborland mborland deleted the gcc-5 branch February 10, 2022 12:58
@ckormanyos
Copy link
Member

I can merge this in then; GCC-5 didn't encounter any issues

Great. Thank you Matt (@mborland)

We can now for 1.79 with fairness and clarity document Math and Multiprecision to go back to GCC-5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants