Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependency for six (>=1.7.3,<=1.8.0) #41

Closed
wants to merge 1 commit into from

Conversation

bosr
Copy link

@bosr bosr commented Dec 11, 2014

because awscli requires six 1.8.0 and boto3 works fine with it.

because awscli requires six 1.8.0 and boto3 works fine with it.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6a74499 on bosr:six_dependency into 2190b6b on boto:develop.

@danielgtaylor
Copy link
Member

@bosr thanks for the pull request! I've looked into this a bit more, and it turns out I'm not even using six anymore since moving to using Botocore for data loading in 4b0a2f5. I think that I'm just going to remove the dependency on six completely, and if we need it in the future we can expose it via the version that ships with Botocore.

@danielgtaylor danielgtaylor added the enhancement This issue requests an improvement to a current feature. label Dec 11, 2014
@danielgtaylor danielgtaylor self-assigned this Dec 11, 2014
@bosr
Copy link
Author

bosr commented Dec 11, 2014

Perfect. Thanks !

Romain

On 11 Dec 2014, at 22:42, Daniel G. Taylor notifications@github.com wrote:

@bosr thanks for the pull request! I've looked into this a bit more, and it turns out I'm not even using six anymore since moving to using Botocore for data loading in 4b0a2f5. I think that I'm just going to remove the dependency on six completely, and if we need it in the future we can expose it via the version that ships with Botocore.


Reply to this email directly or view it on GitHub.

@bosr bosr closed this Dec 11, 2014
@bosr bosr deleted the six_dependency branch December 15, 2014 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue requests an improvement to a current feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants