Handle checksums on copy #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
previously requested changes
Jun 17, 2022
There was a problem hiding this comment.
Hi @rapkyt,
Thanks for the PR! I've left some quick feedback. Overall, I think this is looking good, just a few more changes should get it ready to ship. Please let us know if you have any questions.
|
I am also blocked on this PR. If possible, do we have an ETA for this to be merged? |
|
@nateprewitt I've made the requested changes, |
|
do we have an ETA for this merge? and then release? |
|
Hi everyone, any chance we can help get this done? The possibility of using aws' checksums is very welcome for all those doing checksums for data integrity purposes. |
|
This not being merged is currently blocking me. What are we waiting on @nateprewitt ? |
jonathan343
dismissed
nateprewitt’s stale review
Requested changes were addressed by the author.
aws-sdk-python-automation
added a commit
that referenced
this pull request
May 4, 2023
* release-0.6.1: Bumping version to 0.6.1 Handle checksums on copy (#242) Update block public access settings Use codecov-action instead of pip installing. Fix isort version (#263) Bump wheel from 0.37.0 to 0.38.1 (#261) Move CI to release 3.11 build (#259) Update lockfile to fix atomicwrite (#245) Add testing and classifier for Python 3.11 (#243)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3.Object.copy()fails with multipart andChecksumAlgorithmas mentioned in #241This fixes the issue by adding the checksum information to
CompleteMultipartUpload