build: use static files instead of /dev/null #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unintended consequence of this `path = "/dev/null"` in the Cargo.toml files of packages and variants is that a change to the device causes a complete rebuild of all of Bottlerocket. So, for example, restarting a machine would cause Bottlerocket to rebuild all packages. This was an issue in the new Twoliter build system because each time Twoliter is executed, a container is created with a different /dev/null device, triggering a full rebuild. Though less cool, this commit points all packages at a single packages.rs file and all variants at a variants.rs file to fix this problem.
This was referenced Jul 24, 2023
Merged
bcressey
approved these changes
Jul 24, 2023
arnaldo2792
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to #2669 and Twoliter #14
Description of changes:
An unintended consequence of this
path = "/dev/null"in the Cargo.toml files of packages and variants is that a change to the device causes a complete rebuild of all of Bottlerocket. So, for example, restarting a machine would cause Bottlerocket to rebuild all packages.This was an issue in the new Twoliter build system because each time Twoliter is executed, a container is created with a different /dev/null device, triggering a full rebuild.
Though less cool, this commit points all packages at a single packages.rs file and all variants at a variants.rs file to fix this problem.
Testing done:
cargo makeworks. It fixes the Twoliter problem.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.