Search update #55
Merged
Search update #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok. There's a lot of duplication in the three code blocks now, how about using a function? |
|
Hate doing this, but I had a bit of a problem getting this to work properly, and I really want to have search working, so I am going to have to go ahead and merge this as-is and worry about code quality a bit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hugovk Would you be interested in looking at this?
I was just playing with PHP here, trying to tweak the code/numbers to see what would give the best results (#19). I mostly tried searching for
@tiny_star_fieldwith keywords liketinystarfiedtiny starfieldtinystarfield, etc.I left the
ANDsearch mode strict, for now.