Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guard replacement for all 1D variables #11

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add guard replacement for all 1D variables #11

wants to merge 5 commits into from

Conversation

mikekryjak
Copy link
Collaborator

@mikekryjak mikekryjak commented May 22, 2024 •
edited
Loading

Resolves #6.

  • Makes sure y position guard replacement is done only if guard replacement is on
  • Corrects position calculation so that it's zero at the domain boundary

@mikekryjak
Copy link
Collaborator Author

This seems to do something odd to the pos dimension, please check it. Also test whether variables are actually guard replaced correctly

@mikekryjak mikekryjak marked this pull request as draft June 10, 2024 14:14
@mikekryjak
Copy link
Collaborator Author

This needs to ensure that sources are not guard replaced, and instead their guard cell values set to zero as per bendudson/hermes-3#98

@mikekryjak
Disable snipping off outer guards by default as it's confusing
2a3661a 
- Much better to always include all guard cells so that you know what to expect and take them off as needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent guard replacement
1 participant
@mikekryjak