Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE10 issue with __defineGetter__ #293

Merged
merged 1 commit into from
May 19, 2015
Merged

Conversation

rouanw
Copy link
Contributor

@rouanw rouanw commented May 19, 2015

This commit changes fontWrapper.js to use the standardized defineProperty function instead of __defineGetter__ which is not supported in Internet Explorer 10 and lower.

…r__ which is not supported in Internet Explorer 10 and lower
@jthoenes
Copy link
Contributor

Cool, thanks!

@jthoenes jthoenes closed this May 19, 2015
@jthoenes jthoenes reopened this May 19, 2015
jthoenes added a commit that referenced this pull request May 19, 2015
Fix IE10 issue with __defineGetter__
@jthoenes jthoenes merged commit dd116c5 into bpampuch:master May 19, 2015
@swd-mf
Copy link

swd-mf commented Jun 12, 2015

I've been having the same problem as this but using pdfmake.min.js. Are there any plans to incorporate this fix (and also fix in Issue #294) into pdfmake.min.js ?

@rouanw
Copy link
Contributor Author

rouanw commented Jun 12, 2015

Hi @jb-mf. You're most likely experiencing this because the IE10 fixes have not yet been released. @bpampuch should be able to tell you when the next pdfmake release is planned. In the meantime, I'm pointing to a branch on my fork (https://github.com/rouanw/pdfmake), on which I've released the changes. You can reference this in your bower.json like so:

"pdfmake": "rouanw/pdfmake#bower",

@swd-mf
Copy link

swd-mf commented Jun 12, 2015

Hi @rouanw Thanks for the quick reply. I've bbbeen using pdfmake simply by linking my html to pdfmake.min.js and vfs_fonts.js. Thanks for the link to your fork. Unfortunately, I don't often use bower but I guess this is an opportunity for me to learn it better :-)

Thanks

JB

@rouanw
Copy link
Contributor Author

rouanw commented Jun 12, 2015

@jb-mf If you just want the files, you can clone the repo and build the pdfmake.min.js and vfs_fonts.js files locally. (You'd have to host them yourself if you're not already.)

git clone https://github.com/bpampuch/pdfmake.git
npm install
gulp

You'll find the built files in the build folder.

@swd-mf
Copy link

swd-mf commented Jun 12, 2015

@rouanw Thanks. I've been meaning to try out Bower for a while but never had time. I'm going to give it a go, but if I get stuck I'll clone the repo like you suggest.

@moffsugita
Copy link
Contributor

moffsugita commented Nov 30, 2018

Good Table

#800

I hope it should be in README ;>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants