Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add colors configuration #11

Closed
barmac opened this issue Dec 6, 2022 · 0 comments
Closed

Add colors configuration #11

barmac opened this issue Dec 6, 2022 · 0 comments
Assignees
@nikku
Labels
enhancement New feature or request

Comments

@barmac
Copy link
Member

barmac commented Dec 6, 2022

Is your feature request related to a problem? Please describe

Currently, the colors are hardcoded, and I need to fork the project in order to introduce own sets. Let's make it configurable.

Describe the solution you'd like

Pass config.colors to the Modeler to set my own color set based on https://github.com/bpmn-io/bpmn-js-color-picker/blob/master/colors/ColorPopupProvider.js#L20

Describe alternatives you've considered

Do nothing.

Additional context
@barmac barmac added the enhancement New feature or request label Dec 6, 2022
This was referenced Dec 6, 2022
Closed
Closed
nikku added a commit that referenced this issue Dec 6, 2022
@nikku
feat: be able to provide custom colors
dfedd94 
Using the `colorPicker.colors` configuration users can provide
custom colors to the extension. Not documented, as not advisable.

Closes #11
nikku added a commit that referenced this issue Dec 6, 2022
@nikku
feat: be able to provide custom colors
7594ba2 
Using the `colorPicker.colors` configuration users can provide
custom colors to the extension. Not documented, as not advisable.

Closes #11
@nikku nikku mentioned this issue Dec 6, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 6, 2022
@fake-join fake-join bot closed this as completed in 8bd0988 Dec 9, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikku @barmac