Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added configuration default fill color and default stroke color #26

Merged
merged 2 commits into from
May 25, 2023

Conversation

zxuanhong
Copy link
Contributor

  1. Added configuration default fill color and default stroke color.This makes some special environment display better(such as dark mode).This configuration is consistent with bpmn js
  2. Adjust the color svg icon stroke-width to equal 2 so that the border color is clearer
iShot_2023-05-25_15 55 38 iShot_2023-05-25_15 55 15

1. Added configuration default fill color and default stroke color
2. Change the color svg icon stroke-width to equal 2 so that the border color is clearer
@zxuanhong
Copy link
Contributor Author

@smbea
I added the configuration default fill color and default stroke color. This scheme is consistent with bpmn js.The configuration of bpmn js is as follows
image

@smbea
Copy link

smbea commented May 25, 2023

Adjust the color svg icon stroke-width to equal 2 so that the border color is clearer

I'm not sure we want to change the stroke. We've had some discussions on the UI of the color picker but I don't remember if this was an issue that was discussed @nikku

@nikku
Copy link
Member

nikku commented May 25, 2023

@zxuanhong Could you tell us why we don't simply set this to the default fill and stroke color provided by bpmn-js? Why would we want to set this extra?

@zxuanhong
Copy link
Contributor Author

zxuanhong commented May 25, 2023

@nikku In Dark mode, the color without fill or stroke should follow bpmn js in Dark mode.Or this will result in a color mismatch with bpmn js(bpmn js changes the default color situation).That is, bpmn js does the following
image
image

This causes the element color to differ from the corresponding setting

@nikku
Copy link
Member

nikku commented May 25, 2023

Exactly. This is why I'm asking:

@zxuanhong
Copy link
Contributor Author

@nikku I haven't tried to read it, but the idea is perfect. I'll update it later

Read the default fill color and the default stroke color set by bpmn js
render. Avoid redundant code
@zxuanhong
Copy link
Contributor Author

@nikku Have changed
iShot_2023-05-25_22 02 02
iShot_2023-05-25_22 01 56

@zxuanhong
Copy link
Contributor Author

@nikku Thanks again for your guidance

@nikku
Copy link
Member

nikku commented May 25, 2023

Great stuff @zxuanhong. Feels like the right approach.

@nikku nikku merged commit a97a626 into bpmn-io:master May 25, 2023
@nikku
Copy link
Member

nikku commented Jun 1, 2023

Released with v0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants