-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added configuration default fill color and default stroke color #26
Conversation
zxuanhong
commented
May 25, 2023
- Added configuration default fill color and default stroke color.This makes some special environment display better(such as dark mode).This configuration is consistent with bpmn js
- Adjust the color svg icon stroke-width to equal 2 so that the border color is clearer
1. Added configuration default fill color and default stroke color 2. Change the color svg icon stroke-width to equal 2 so that the border color is clearer
@smbea |
I'm not sure we want to change the stroke. We've had some discussions on the UI of the color picker but I don't remember if this was an issue that was discussed @nikku |
@zxuanhong Could you tell us why we don't simply set this to the default fill and stroke color provided by bpmn-js? Why would we want to set this extra? |
@nikku In Dark mode, the color without fill or stroke should follow bpmn js in Dark mode.Or this will result in a color mismatch with bpmn js(bpmn js changes the default color situation).That is, bpmn js does the following This causes the element color to differ from the corresponding setting |
Exactly. This is why I'm asking:
|
@nikku I haven't tried to read it, but the idea is perfect. I'll update it later |
Read the default fill color and the default stroke color set by bpmn js render. Avoid redundant code
@nikku Have changed |
@nikku Thanks again for your guidance |
Great stuff @zxuanhong. Feels like the right approach. |
Released with v0.6.0. |