-
Notifications
You must be signed in to change notification settings - Fork 1.3k
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-selection in viewer causes black boxes #2135
Comments
I think that we need to be clear on what a viewer is. The default viewer in my opinion, should behave like viewing an SVG. No interactivity at all. I never liked the fact that you get selection behavior in the viewer. Now, there are use cases that need an interactive viewer. In these cases, users need to include the required features and stylesheets as well. Alternatively, we could offer something similar to the navigated viewer. |
No interactivity means that you cannot properly react to states in i.e. overlays. Hence the viewer would always offer basic interactivity, including hover and selection. |
Overlays is a feature of an interactive viewer, I'd say. |
I'd say there are 4 ways to display diagram:
Otherwise we should rename the Viewer to Renderer, as that's what it is without any interactivity. |
Thanks for #2135 (comment) @barmac. I subscribe to it. Without interactivity the viewer is simply a renderer. You can roll your own barebones renderer if you so desire on top of the |
Describe the Bug
As a user I'm embedding the viewer as recommended in the starter project. When I select elements no outline is shown, I can still react to selected events; this I expect.
However when I select more than one element a black box appears that hides the diagram:
Steps to Reproduce
SHIFT + click
Expected Behavior
Environment
The text was updated successfully, but these errors were encountered: