Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextPadProvider d.ts file has wrong type difinition #2203

Open
J4CKVVH173 opened this issue Jul 10, 2024 · 4 comments
Open

ContextPadProvider d.ts file has wrong type difinition #2203

J4CKVVH173 opened this issue Jul 10, 2024 · 4 comments
Labels
backlog Queued in backlog bug Something isn't working good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day

Comments

@J4CKVVH173
Copy link
Contributor

I installed bpmn-js via npm and wrote custom ContexPad. I extended my class by bpmn-js/lib/features/context-pad/ContextPadProvider and used constructor. ts said that there are 12 constructor's props (screenshot 1). But when i've tried to use the system - i've got an error. I did a research and found out that ContextPadProvider in ContextPadProvider.js file has extra prop (there are 13 constructor props in source js file - screenshot 2).
image

image

@J4CKVVH173 J4CKVVH173 added the bug Something isn't working label Jul 10, 2024
@barmac
Copy link
Member

barmac commented Jul 15, 2024

Indeed, the typescript definition looks incomplete. Would you like to file a pull request which fixes the problem?

@barmac barmac added pr welcome We rely on a community contribution to improve this. good first issue Good for newcomers backlog Queued in backlog spring cleaning Could be cleaned up one day labels Jul 15, 2024
@J4CKVVH173
Copy link
Contributor Author

i could but i can't find d.ts file into the repository. i checked that the lib in common has 'pure js files' but where is the d.ts i don't have any clue

@barmac
Copy link
Member

barmac commented Jul 16, 2024

The type declarations are generated from JSDocs with bio-dts. To fix the problem, you'd need to change the JSDoc of the constructor.

@J4CKVVH173
Copy link
Contributor Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day
Development

No branches or pull requests

2 participants