Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ContextPadProvider types #2204

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fixed ContextPadProvider types #2204

merged 1 commit into from
Jul 23, 2024

Conversation

J4CKVVH173
Copy link
Contributor

Proposed Changes

Fix the issue. Added type to the function's constructor.

Related to {https://github.com/bpmn-io/bpmn-js/issues/2203}

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • [] Visual demo attached
  • [] Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2024

CLA assistant check
All committers have signed the CLA.

@barmac
Copy link
Member

barmac commented Jul 16, 2024

Thanks! Could you also provide a type test to this contribution? Look at this file as an example: https://github.com/bpmn-io/bpmn-js/blob/main/lib/BaseModeler.spec.ts

@J4CKVVH173
Copy link
Contributor Author

I didn't get the idea. I need to create an instance of ContextPadProvider and then what?

@barmac
Copy link
Member

barmac commented Jul 17, 2024

This code is not run, we just want to verify that the typescript compiler passes.

@barmac barmac self-requested a review July 17, 2024 12:06
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nikku nikku merged commit 37eadc3 into bpmn-io:develop Jul 23, 2024
2 checks passed
@nikku
Copy link
Member

nikku commented Jul 23, 2024

@barmac I decided to merge this one; as this is not about external API improvement, but internal typing I'm afraid there is not much we can simply test here.

nikku pushed a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants