Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lane resize constraints do not work when resizing from bottom right corner with any lane but the lowest one #2209

Closed
StefanLerch opened this issue Jul 30, 2024 · 1 comment · Fixed by #2218
Closed

Lane resize constraints do not work when resizing from bottom right corner with any lane but the lowest one #2209

StefanLerch opened this issue Jul 30, 2024 · 1 comment · Fixed by #2218
Assignees
@abdul99ahad
Labels
bug Something isn't working good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day

Comments

@StefanLerch
Copy link

Describe the Bug

The lane resize constraints do not work when using any lane except for the lowest one of the participant and using the bottom right corner of the lane.

chrome_3YOVUbaBhp

Steps to Reproduce

  1. Create a pool with at least two lanes
  2. Insert an element into one of the lanes
  3. Resize any but the lowest lane with the direction "se"

Result: The width of the lane can be decreased beyond the elements inside of it.

Expected Behavior

The participant and therefore one of the lanes should always contain all elements. It should not be possible to decrease the x coordinate of a lane/participant beyond that of the elements inside of it.

Environment

  • Browser: Chrome v127.0.6533.73
  • OS: Windows 11 Enterprise
  • Library version: 17.6.4, also demo
@StefanLerch StefanLerch added the bug Something isn't working label Jul 30, 2024
@barmac
Copy link
Member

barmac commented Aug 2, 2024

Thanks for reporting. I can reproduce this issue. I will move it to the backlog, but if you are interested in providing a pull request fixing this, we will be happy to review it.

@barmac barmac added good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. backlog Queued in backlog spring cleaning Could be cleaned up one day labels Aug 2, 2024
@abdul99ahad abdul99ahad added ready Ready to be worked on in progress Currently worked on and removed ready Ready to be worked on backlog Queued in backlog labels Aug 6, 2024
abdul99ahad added a commit that referenced this issue Aug 13, 2024
@abdul99ahad
fix: lane resize constraint for se and nw correct
c720bfa 
Closes #2209
abdul99ahad added a commit that referenced this issue Aug 13, 2024
@abdul99ahad
fix: lane resize constraint for se and nw correct
270525d 
Closes #2209
abdul99ahad added a commit that referenced this issue Aug 13, 2024
@abdul99ahad
fix: lane resize constraint for se and nw correct
ff289b3 
Closes #2209
@abdul99ahad abdul99ahad added the needs review Review pending label Aug 13, 2024 — with bpmn-io-tasks
@abdul99ahad abdul99ahad removed the in progress Currently worked on label Aug 13, 2024
abdul99ahad added a commit that referenced this issue Aug 16, 2024
@abdul99ahad
fix: lane resize constraints
f769d0e 
Closes #2209
abdul99ahad added a commit that referenced this issue Aug 19, 2024
@abdul99ahad
fix: lane resize constraints for horizontal and vertical lanes
0b4ed5f 
Closes #2209
abdul99ahad added a commit that referenced this issue Aug 19, 2024
@abdul99ahad
fix: lane resize constraints for horizontal and vertical lanes
7e3ba5f 
Closes #2209
abdul99ahad added a commit that referenced this issue Aug 19, 2024
@abdul99ahad
fix: lane resize constraints for horizontal and vertical lanes
de996a4 
Closes #2209
@nikku nikku mentioned this issue Aug 20, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Aug 28, 2024
abdul99ahad added a commit that referenced this issue Aug 28, 2024
@abdul99ahad
fix: lane resize constraints for horizontal and vertical lanes
7e5a772 
Closes #2209
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 28, 2024
nikku pushed a commit that referenced this issue Aug 28, 2024
@abdul99ahad @nikku
fix: lane resize constraints for horizontal and vertical lanes
cc9acb0 
Closes #2209
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 28, 2024
nikku pushed a commit that referenced this issue Sep 9, 2024
@abdul99ahad @nikku
fix: lane resize constraints for horizontal and vertical lanes
7a137cc 
Closes #2209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdul99ahad abdul99ahad

Labels
bug Something isn't working good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: lane resize constraint bpmn-io/bpmn-js
3 participants
@barmac @abdul99ahad @StefanLerch