Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle elements without label when using search #2234

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Sep 12, 2024

Proposed Changes

Elements like associations don't have any label which we could use for comparison when sorting the search results.

brave_D6YdY33A8m

Closes #2232

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@nikku nikku merged commit 58d7d7a into develop Sep 16, 2024
12 checks passed
@nikku nikku deleted the 2232-search-fix branch September 16, 2024 16:01
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 16, 2024
@nikku
Copy link
Member

nikku commented Sep 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Search blows up in huge diagram
2 participants