Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed erDiagram being whitespace sensitive where it shouldn't #118

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

Logerfo
Copy link
Contributor

@Logerfo Logerfo commented Oct 30, 2023

No description provided.

@@ -42,12 +42,12 @@
name: keyword.control.mermaid
- comment: '(entity) (relationship) (entity) : (label)'
match: !regex |-
\s*([\w-]+)\s+ # entity
\s*([\w-]+)\s() # entity
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a capture group or should it be a * similar to the other changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed!

@bpruitt-goddard
Copy link
Owner

Looks good. Can a test or two be added to the associated test file? Perhaps one of the relationship lines can be modified to reflect the change? Note you'll need to update the commented lines afterword to ensure the caret ^ symbols line up with the proper positions. You can then validate the tests via these commands (from the root of the project) npm run convertYaml && npm test

@Logerfo
Copy link
Contributor Author

Logerfo commented Oct 31, 2023

@bpruitt-goddard

C:\repos\vscode-mermaid-syntax-highlight  patch-1  ~1    20.5.0 ﴱ dev0 
npm run convertYaml && npm test

> mermaid-markdown-syntax-highlighting@1.5.3 convertYaml
> node build/ConvertYaml.js


> mermaid-markdown-syntax-highlighting@1.5.3 test
> vscode-tmgrammar-test 'tests/**/*.test.{mermaid,md}'

ERROR no test cases found

@bpruitt-goddard
Copy link
Owner

Any chance you are on windows? I think there is a bug on Windows with the test library that is fixed by changing the quotes on the glob pattern. Can you try making this change here in package.json and see if that picks up the tests?

"test": "vscode-tmgrammar-test \"tests/**/*.test.{mermaid,md}\""

@Logerfo
Copy link
Contributor Author

Logerfo commented Nov 3, 2023

@bpruitt-goddard what do you think?

@bpruitt-goddard bpruitt-goddard merged commit e320e0a into bpruitt-goddard:master Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants