Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #62

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Update dependencies #62

merged 7 commits into from
Sep 6, 2023

Conversation

oscarleonnogales
Copy link
Contributor

@oscarleonnogales oscarleonnogales commented Aug 21, 2023

Summary

  • Created constants.ts file and moved constants definitions.
  • Updated dependencies (all minor updates except for TypeScript, which was upgraded to the next major version)
  • Update node to v18

For internal tracking -> 2912

@oscarleonnogales oscarleonnogales marked this pull request as ready for review August 21, 2023 20:34
@oscarleonnogales oscarleonnogales requested a review from a team as a code owner August 21, 2023 20:34
Copy link
Contributor

@jplukarski jplukarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are failing because the unit tests are not pointing to the public NPM registry. You'll have to look at the package-lock and amend any package not pointing to the correct registry @oscarleonnogales .

@oscarleonnogales
Copy link
Contributor Author

Looks like tests are failing because the unit tests are not pointing to the public NPM registry. You'll have to look at the package-lock and amend any package not pointing to the correct registry @oscarleonnogales .

Done!

@jplukarski jplukarski merged commit 105c386 into main Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants