This repository has been archived by the owner on May 12, 2020. It is now read-only.
Add support for conditional matching filters based on tags #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
approved these changes
Mar 3, 2019
| @@ -1472,6 +1495,15 @@ int serializeFilters(char * buffer, size_t bufferSizeAvail, | |||
| } | |||
| bufferSize++; | |||
|
|
|||
| if (f->tagLen > 0) { | |||
| if (buffer) { | |||
| buffer[bufferSize] = '#'; | |||
There was a problem hiding this comment.
Is it safe to assume the buffer has the space available for this additional data? Wasn't quite sure how that side of things works.
There was a problem hiding this comment.
Yep how it works is it calls the function 2 times. The first with nullptr buffer to get the size. The second it specifies a buffer of that size.
SergeyZhukovsky
approved these changes
Mar 4, 2019
bbondy
force-pushed
the
condition-tagging
branch
3 times, most recently
from
d8ec43b
to
e8b9af3
Compare
19 tasks
bbondy
force-pushed
the
condition-tagging
branch
from
e8b9af3
to
ba76cab
Compare
bbondy
force-pushed
the
condition-tagging
branch
from
ba76cab
to
8ddfa91
Compare
This was referenced Mar 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for a description of the task:
Fix #191