Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor wallet SelectedAccount entity #31013

Closed
supermassive opened this issue Jun 13, 2023 · 2 comments · Fixed by brave/brave-core#18930
Closed

Refactor wallet SelectedAccount entity #31013

supermassive opened this issue Jun 13, 2023 · 2 comments · Fixed by brave/brave-core#18930
Labels
dev-concern feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.58.x - Release

Comments

@supermassive
Copy link

Instead of
GetSelectedCoin()->coin SetSelectedCoin(coin)
GetSelectedAccount(coin)->account SetSelectedAccount(coin, account)
we need
GetSelectedAccount()->account SetSelectedAccount(account)
GetSelectedEthDappAccount()->account
GetSelectedSolDappAccount()->account
wallet APIs

Per coin selected account is needed only for dApps and doesn't make sense for bitcoin and filecoin
@supermassive supermassive added dev-concern QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 13, 2023
@supermassive supermassive mentioned this issue Jun 15, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 10, 2023
@StephenHeaps StephenHeaps mentioned this issue Jul 12, 2023
Closed
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.108 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision f08ffbe3ce0069ad8207b9d2d7dee38afcccc1b9
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified wallet works as expected

@supermassive supermassive mentioned this issue Sep 4, 2023
Open
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.58.117 x64 build

  • Verified wallet works as expected
  • Encountered #32791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Refactor Wallet SelectedAccount brave/brave-core
3 participants
@supermassive @srirambv @brave-builds