Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Wallet Selected Account Refactor #7723

Closed
StephenHeaps opened this issue Jul 12, 2023 · 1 comment · Fixed by #7725
Closed

Wallet Selected Account Refactor #7723

StephenHeaps opened this issue Jul 12, 2023 · 1 comment · Fixed by #7725
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.58

Comments

@StephenHeaps
Copy link
Contributor

Description:

Address changes with the Selected Account Refactor in BraveCore.

selectedCoin/setSelectedCoin no longer exist. Instead we get the selectedAccount, ethDappSelectedAccount, and solDappSelectedAccount from KeyringService's GetAllAccounts().

EnsureSelectedAccountForChain(CoinType coin, string chain_id) => (AccountId? account_id); was added to WalletService select the correct account (if needed) after changing network. This helps avoid race conditions previously hit when switching account/network.
@StephenHeaps StephenHeaps added this to the 1.58 milestone Jul 12, 2023
@StephenHeaps StephenHeaps self-assigned this Jul 12, 2023
@StephenHeaps StephenHeaps mentioned this issue Jul 12, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps linked a pull request Jul 19, 2023 that will close this issue
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 #7725
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Jul 20, 2023
@StephenHeaps
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 (#7725
caa8400 
)

* Resolve account selection, network selection, buy, send, swap, DApp connections, other stores.

* Resolve unit tests.

* Update BraveCore to v1.58.10

* Update BraveCore to v1.58.26
StephenHeaps added a commit that referenced this issue Jul 25, 2023
@StephenHeaps
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 (#7725
e25571d 
)

* Resolve account selection, network selection, buy, send, swap, DApp connections, other stores.

* Resolve unit tests.

* Update BraveCore to v1.58.10

* Update BraveCore to v1.58.26
StephenHeaps added a commit that referenced this issue Jul 31, 2023
@StephenHeaps
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 (#7725
5bffadf 
)

* Resolve account selection, network selection, buy, send, swap, DApp connections, other stores.

* Resolve unit tests.

* Update BraveCore to v1.58.10

* Update BraveCore to v1.58.26
StephenHeaps added a commit that referenced this issue Aug 2, 2023
@StephenHeaps
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 (#7725
95741a0 
)

* Resolve account selection, network selection, buy, send, swap, DApp connections, other stores.

* Resolve unit tests.

* Update BraveCore to v1.58.10

* Update BraveCore to v1.58.26
Brandon-T pushed a commit that referenced this issue Aug 10, 2023
@StephenHeaps @Brandon-T
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 (#7725
eafaaa6 
)

* Resolve account selection, network selection, buy, send, swap, DApp connections, other stores.

* Resolve unit tests.

* Update BraveCore to v1.58.10

* Update BraveCore to v1.58.26
StephenHeaps added a commit that referenced this issue Aug 10, 2023
@StephenHeaps
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 (#7725
78bf40d 
)

* Resolve account selection, network selection, buy, send, swap, DApp connections, other stores.

* Resolve unit tests.

* Update BraveCore to v1.58.10

* Update BraveCore to v1.58.26
StephenHeaps added a commit that referenced this issue Aug 11, 2023
@StephenHeaps
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 (#7725
299b992 
)

* Resolve account selection, network selection, buy, send, swap, DApp connections, other stores.

* Resolve unit tests.

* Update BraveCore to v1.58.10

* Update BraveCore to v1.58.26
StephenHeaps added a commit that referenced this issue Aug 17, 2023
@StephenHeaps
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 (#7725
af95d68 
)

* Resolve account selection, network selection, buy, send, swap, DApp connections, other stores.

* Resolve unit tests.

* Update BraveCore to v1.58.10

* Update BraveCore to v1.58.26
nuo-xu pushed a commit that referenced this issue Aug 18, 2023
@StephenHeaps @nuo-xu
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 (#7725
5324181 
)

* Resolve account selection, network selection, buy, send, swap, DApp connections, other stores.

* Resolve unit tests.

* Update BraveCore to v1.58.10

* Update BraveCore to v1.58.26
nuo-xu pushed a commit that referenced this issue Aug 21, 2023
@StephenHeaps @nuo-xu
Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 (#7725
f147c0e 
)

* Resolve account selection, network selection, buy, send, swap, DApp connections, other stores.

* Resolve unit tests.

* Update BraveCore to v1.58.10

* Update BraveCore to v1.58.26
@StephenHeaps StephenHeaps mentioned this issue Sep 21, 2023
Closed
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 15.7.8 running 1.58 (23.9.21.21)

  • Verified steps from #7725
  • Verified able to switch between accounts/network in panel
  • Verified able to connect to a Dapp successfully
  • Verified when multiple accounts are there and selected account is shown as default when trying to connect to a Dapp
  • Verified able to switch networks/accounts in Buy screen
  • Verified able to switch tokens from accounts in Send screen
  • Verified switching network automatically switches accounts on Swap screen
  • Verified selecting a token and selecting Send/Swap from the token details page pre-populates the token in the Send/Swap screen respectively
  • Verified able to add Ethereum/Solana/Filecoin accounts

Verification passed on iPhone 13 with iOS 17 running 1.58 (23.9.21.21)

  • Verified steps from #7725
  • Verified able to switch between accounts/network in panel
  • Verified able to connect to a Dapp successfully
  • Verified when multiple accounts are there and selected account is shown as default when trying to connect to a Dapp
  • Verified able to switch networks/accounts in Buy screen
  • Verified able to switch tokens from accounts in Send screen
  • Verified switching network automatically switches accounts on Swap screen
  • Verified selecting a token and selecting Send/Swap from the token details page pre-populates the token in the Send/Swap screen respectively
  • Verified able to add Ethereum/Solana/Filecoin accounts

Verification passed on iPad with iOS 16.7 running 1.58 (23.9.21.21)

  • Verified steps from #7725
  • Verified able to switch between accounts/network in panel
  • Verified able to connect to a Dapp successfully
  • Verified when multiple accounts are there and selected account is shown as default when trying to connect to a Dapp
  • Verified able to switch networks/accounts in Buy screen
  • Verified able to switch tokens from accounts in Send screen
  • Verified switching network automatically switches accounts on Swap screen
  • Verified selecting a token and selecting Send/Swap from the token details page pre-populates the token in the Send/Swap screen respectively
  • Verified able to add Ethereum/Solana/Filecoin accounts

@Uni-verse Uni-verse mentioned this issue Nov 27, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.58
Development

Successfully merging a pull request may close this issue.

Fix #7723: Selected Account Refactor & Bump BraveCore to v1.58.26 brave/brave-ios
2 participants
@StephenHeaps @srirambv