-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTP always shows the same background image #32359
Comments
Now same issue happens on my device. The issue happens only on a specific browser profile. NTP changes randomly on other profiles. Brave 1.57.53 2023-08-24.11.32.55.mov |
fix brave/brave-browser#32359 Sometimes we could meet the condition that ViewCounterModel::count_to_branded_wallpaper_ is zero and no SI campaign. When this happens, we didn't increase background wallpaper index. This caused showing same background image till new campaign starts. We should increase background images index in this situation also.
The above requires |
Verified with
Used "Manual Test" steps from brave/brave-core#19896 (comment) and Upgrade Profile - PASSED
Clean Profile - PASSED
|
Description
https://community.brave.com/t/topic/500776
NTP shows same image no matter how many times they reload NTP.
Steps to Reproduce
Actual result:
The same background image shows
Expected result:
Shows other background images randomly
Reproduces how often:
Easily reproduced(only on specific devices)
Brave version (brave://version info)
v1.57.47
Windows10
The text was updated successfully, but these errors were encountered: