Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News]: Persist Following/For You preference across browser sessions #35968

Closed
Tracked by #35960
LorenzoMinto opened this issue Feb 12, 2024 · 2 comments · Fixed by brave/brave-core#22362
Closed
Tracked by #35960

[Brave News]: Persist Following/For You preference across browser sessions #35968

LorenzoMinto opened this issue Feb 12, 2024 · 2 comments · Fixed by brave/brave-core#22362
Assignees
@fallaciousreasoning
Labels
feature/brave-news formerly brave-today OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.63.x - Release #5

Comments

@LorenzoMinto
Copy link
Member

LorenzoMinto commented Feb 12, 2024 •
edited by kjozwiak
Loading

@brave/qa-team can use brave/brave-core#22362 (comment) as a template for verification(s).
@LorenzoMinto LorenzoMinto mentioned this issue Feb 12, 2024
Open
@LorenzoMinto LorenzoMinto added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes OS/Desktop release-notes/exclude feature/brave-news formerly brave-today labels Feb 12, 2024
@fallaciousreasoning fallaciousreasoning mentioned this issue Feb 28, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 28, 2024
This was referenced Mar 8, 2024
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Mar 9, 2024

The above requires 1.63.172 or higher for 1.63.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.63.174 Chromium: 122.0.6261.128 (Official Build) (64-bit)
-- | --
Revision | 0d369d4e1dfee7bcea82774079dc8cd658746c98
OS | Windows 10 Version 22H2 (Build 19045.4046)

Reproduced the issue on 1.63.169 Chromium: 122.0.6261.111 last selected Feed isn't respected when re-opening NTP

Using the STR/Cases outlined via brave/brave-core#22362 (comment), ensured that the last selected Feed view is saved/respected when re-opening NTP. Went through the following:

Test Case #1 - Following

  • opened a NTP and selected Following as the default view
  • closed the NTP/restarted Brave
  • re-opened a NTP and scrolled down to the Brave News Feed and ensured Following was selected/displayed

Test Case #2 - Top Sources

  • opened a NTP and selected Top Sources as the default view
  • closed the NTP/restarted Brave
  • re-opened a NTP and scrolled down to the Brave News Feed and ensured Top Sources was selected/displayed

Test Case #3 - Imported RSS feed

  • opened a NTP and selected a Imported RSS as the default view
  • closed the NTP/restarted Brave
  • re-opened a NTP and scrolled down to the Brave News Feed and ensured Imported RSS was selected/displayed

Test Case #4 - For You

  • opened a NTP and selected a Imported RSS as the default view
  • closed the NTP/restarted Brave
  • re-opened a NTP and scrolled down to the Brave News Feed and ensured Imported RSS was selected/displayed

@LaurenWags LaurenWags mentioned this issue Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
feature/brave-news formerly brave-today OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.63.x - Release #5
Development

Successfully merging a pull request may close this issue.

[Brave News]: Remember last Feed View brave/brave-core
5 participants
@kjozwiak @fallaciousreasoning @LorenzoMinto @GeetaSarvadnya @brave-builds