-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brave News]: Remember last Feed View #22362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Q) Maybe this happens only when there is no feed?
A Storybook has been deployed to preview UI for the latest push |
Verification PASSED on
Using the STR/Cases outlined via #22362 (comment), ensured that the last selected
|
Uplift of #22362 (squashed) to beta
Uplift of #22362 (squashed) to release
Resolves brave/brave-browser#35968
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Note: The original issue only repros after the feed from your last refresh is older than 1 hour. To simulate having an old feed run
localStorage.removeItem('feedV2')
in the console just before you close the browser. Depending on your platform you might also needsessionStorage.removeItem('feedV2')