Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Follow up for small screens: Widgets & Stats are not shown for normal window in small screen #39927

Closed
1 of 6 tasks
MadhaviSeelam opened this issue Jul 22, 2024 · 11 comments · Fixed by brave/brave-core#25429

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 22, 2024

Description

Found while testing brave/brave-core#24682. The testing mainly done via external monitor and passed the PR. Responsiveness for NTP worked as expected for the sizes that were mentioned in the PR. However, if I moved normal window from external monitor to 14" laptop screen, widgets, stats are not shown

Steps to reproduce

  1. Installed 1.70.11
  2. launched Brave
  3. opened new tab page in an external monitor
  4. verified stats, top sites, widgets, search widget etc are shown as expected
  5. move the window to 14" screen (or launch NTP independently in 14" screen)

Actual result

2024-07-22_11h05_53

Expected result

2024-07-22_11h37_59

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.70.11 Chromium: 127.0.6533.57 (Official Build) nightly (64-bit)
Revision c9301553de0086ba0b821c29ff7e435ca5c3d82f
OS Windows 11 Version 23H2 (Build 22631.3880)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

@rebron @zenparsing
cc: @brave/qa-team

@MadhaviSeelam MadhaviSeelam changed the title PR Follow up for small screens: Widgets & Stats are not shown for Normal window PR Follow up for small screens: Widgets & Stats are not shown for normal window in small screen Jul 22, 2024
@LaurenWags
Copy link
Member

Brave	1.70.73 Chromium: 128.0.6613.27 (Official Build) nightly (arm64) 
Revision	f21deb89246b4cb37cfdd6c0c823a49b388d5ac5
OS	macOS Version 14.6.1 (Build 23G93)

Reproduces on my 13in macOS M1. My default window size (untouched, clean profile) is:

window size

I don't see stats or widgets/cards on this screen size which could be confusing for a user since under "Customize" these appear to be enabled:

Example Example Example
hidden items no stats no cards

@btlechowski
Copy link

Reproduced on for small window height

Brave	1.70.66 Chromium: 128.0.6613.27 (Oficjalna wersja) nightly (64-bitowa)  
Revision	667a3d64bcaa33f50347e567971f37eeb76758aa
OS	Windows 11 Version 23H2 (Build 22631.3880)

image

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 13, 2024
@aguscruiz
Copy link

@MadhaviSeelam does this happen when you change the screen size without reloading? I didn't quite get that

@LaurenWags
Copy link
Member

@aguscruiz fwiw when I encounter this on my macOS laptop (13 in M1 from 2020) resizing the window does not help. I only see stats/widgets once I go completely full screen. Just resizing my window to be bigger does not help.

@btlechowski
Copy link

I reproduced by resizing the window.

@MadhaviSeelam
Copy link
Author

Win 11 x64 machine:

System display default:

image

Changed screen sizes on 14" laptop screens

clean profile (untouched) screen size changed to see widgets
image image
image image

@LaurenWags
Copy link
Member

This requires 1.70.103 or higher for verification 👍🏻

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 9, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 9, 2024

Verification PASSED on

Brave | 1.70.106 Chromium: 128.0.6613.120 (Official Build) beta (64-bit)
-- | --
Revision | 6dcd96c56e537df5bf4c8ada10264d62028430f7
OS | Windows 10 Version 22H2 (Build 19045.4780)

Verified the issue on small screen resolution laptop 13", opened an NTP and ensured that rewards widget and Brave talk widgets are shown on the NTP with default resolution settings

image

@GeetaSarvadnya GeetaSarvadnya removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 10, 2024
@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Sep 10, 2024

Verification PASSED using

Brave | 1.70.107 Chromium: 128.0.6613.120 (Official Build) beta (64-bit)
-- | --
Revision | ab3f504ca4a15c330f60a93d5e3773d780498980
OS | Windows 11 Version 23H2 (Build 22631.4112)

Verified with original STR from the description #39927 (comment)

Confirmed Widgets & Stats are on shown small screens (14" laptop screen) with default resolution settings

Light mode (sidebar off) Dark mode example example
image 2024-09-10_15h06_40 2024-09-10_15h09_28 image

@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Sep 12, 2024

Verification PASSED using

Brave | 1.70.109 Chromium: 128.0.6613.138 (Official Build) beta (arm64)
Revision | fec4422ae56f4d9680c71a3c1de60b9a8e5ef32f
OS | macOS Version 14.6.1 (Build 23G93)

Verified with original STR from the description #39927 (comment)

Confirmed Widgets & Stats are shown on small screens (macOS arm64 M2 13.6" laptop screen)

Normal window NTPSI w/out sidebar enabled
Screenshot at Sep 12 10-38-15 Screenshot at Sep 12 10-41-47

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave	1.70.110 Chromium: 128.0.6613.138 (Official Build) beta (64-bit) 
Revision	7dec99ca278e09ce2087e9f04914f0aa2507ea4c
OS	Linux

Verified the issue on small screen resolution laptop 13", opened an NTP and ensured that rewards widget and Brave talk widgets are shown on the NTP with default resolution settings

Example Example
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment