Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .git-blame-ignore-revs file #40976

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

cdesouza-chromium
Copy link
Contributor

This file is being added to mirror upstream config settings for it, to avoid issues where the settings for the upstream file interfere with git blaming in brave-core.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This file is being added to mirror upstream config settings for it, to
avoid issues where the settings for the upstream file interfere with
git blaming in brave-core.
@cdesouza-chromium cdesouza-chromium self-assigned this Sep 11, 2024
@cdesouza-chromium cdesouza-chromium requested a review from a team as a code owner September 11, 2024 01:15
@mihaiplesa mihaiplesa merged commit dcd828c into master Sep 11, 2024
5 checks passed
@mihaiplesa mihaiplesa deleted the add-git-blame-ignore-revs branch September 11, 2024 12:36
@goodov
Copy link
Member

goodov commented Sep 13, 2024

we need to do the same for brave-core repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants