Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Fix article click handlers #22365

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#36314

Regression from #21639

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Click on an article in the Brave News feed (not on the title)
  2. The article should open
  3. Repeat for Hero articles

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 28, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.65.75 Chromium: 123.0.6312.29 (Official Build) nightly (64-bit)
-- | --
Revision | b36a621606293cdcba78f0d347e395cbe1d6986b
OS | Windows 11 Version 23H2 (Build 22631.3235)

Using 1.65.43 Chromium: 122.0.6261.94, reproduced the original issue re: not being able to click/open Brave News articles when clicking the background (not the title/images).

Using the STR/Cases outlined via #22365 (comment), ensured that you can click/open articles by clicking on various areas: titles, background, images` as per the following:

clickNews.mp4

kjozwiak pushed a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Brave News]: clean up click targets
4 participants