Fix #8446: Use correct select method on BVC when opening URLs (#8447)

A crash was introduced in #8306 due to accidentally calling the Obj-C `select(_ sender:)` method on UIResponder instead of `select(url:)`.

Sources/Brave/Frontend/Browser/BrowserViewController.swift

@@ -2979,6 +2979,15 @@ extension BrowserViewController: ToolbarUrlActionsDelegate {
     self.tabManager.addTabsForURLs(urls, zombie: false, isPrivate: tabIsPrivate)
   }
 
+#if DEBUG
+  public override func select(_ sender: Any?) {
+    if sender is URL {
+      assertionFailure("Wrong method called, use `select(url:)` or `select(_:action:)`")
+    }
+    super.select(sender)
+  }
+#endif
+
   func select(url: URL) {
     select(url, action: .openInCurrentTab)
   }

Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+BraveTalk.swift

@@ -26,7 +26,7 @@ extension BrowserViewController {
           var components = URLComponents()
           components.host = currentHost
           components.scheme = url.scheme
-          self.select(components.url!)
+          self.select(url: components.url!)
         }
       }
     )

Sources/Brave/Shortcuts/ActivityShortcutManager.swift

@@ -192,7 +192,7 @@ public class ActivityShortcutManager: NSObject {
       } else {
         let controller = NewsSettingsViewController(dataSource: bvc.feedDataSource, openURL: { url in
           bvc.dismiss(animated: true)
-          bvc.select(url)
+          bvc.select(url: url)
         })
         controller.viewDidDisappear = {
           if Preferences.Review.braveNewsCriteriaPassed.value {