Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Commit

Permalink
Ref #7835, #8494: Fix handling of External URL when in third-party fr…
Browse files Browse the repository at this point in the history
…ames but active tab #8495 (#8532)
  • Loading branch information
soner-yuksel committed Dec 7, 2023
1 parent 0984636 commit 6cc5eab
Showing 1 changed file with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -892,12 +892,8 @@ extension BrowserViewController {
}
}
popup.addButton(title: Strings.openExternalAppURLAllow, type: .primary) { [weak tab] () -> PopupViewDismissType in
if UIApplication.shared.canOpenURL(url) {
UIApplication.shared.open(url, options: [:]) { didOpen in
openedURLCompletionHandler(!didOpen)
}
} else {
openedURLCompletionHandler(true)
UIApplication.shared.open(url, options: [:]) { didOpen in
openedURLCompletionHandler(!didOpen)
}
removeTabIfEmpty()
tab?.isExternalAppAlertPresented = false
Expand Down

0 comments on commit 6cc5eab

Please sign in to comment.