Fix #8518: NFT grid placeholder height is not the same with other gri…

…ds height (#8524)
brave · Dec 7, 2023 · abd203e · abd203e
1 parent 819f42e
commit abd203e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Sources/BraveWallet/Crypto/NFT/NFTView.swift b/Sources/BraveWallet/Crypto/NFT/NFTView.swift
@@ -455,7 +455,7 @@ struct SkeletonLoadingNFTView: View {
 
   var body: some View {
     LazyVGrid(columns: nftGrids) {
-      ForEach(0..<6) { _ in
+      ForEach(0..<8) { _ in
         VStack(alignment: .leading, spacing: 6) {
           LoadingNFTView()
             .frame(height: 176)

diff --git a/Sources/BraveWallet/Crypto/NFTImageView.swift b/Sources/BraveWallet/Crypto/NFTImageView.swift
@@ -42,7 +42,6 @@ struct NFTImageView<Placeholder: View>: View {
             WebImage(url: url)
               .resizable()
               .placeholder { placeholder() }
-              .indicator(.activity)
               .aspectRatio(contentMode: .fit)
           } else {
             WebImageReader(url: url) { image in
@@ -77,14 +76,15 @@ struct LoadingNFTView: View {
         Image(braveSystemName: "leo.nft")
           .foregroundColor(Color(braveSystemName: .containerBackground))
           .font(.system(size: floor(viewSize.width / 3)))
+          .aspectRatio(contentMode: .fit)
       }
       .background(
         GeometryReader { geometryProxy in
           Color.clear
             .preference(key: SizePreferenceKey.self, value: geometryProxy.size)
         }
       )
-      .frame(minHeight: viewSize.width, maxHeight: 172)
+      .frame(height: viewSize.width)
       .onPreferenceChange(SizePreferenceKey.self) { newSize in
         viewSize = newSize
       }