Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

"Reopen Last Closed Tab" is shown when no recently closed tabs are there #7897

Closed
hffvld opened this issue Aug 18, 2023 · 1 comment · Fixed by #7919
Closed

"Reopen Last Closed Tab" is shown when no recently closed tabs are there #7897

hffvld opened this issue Aug 18, 2023 · 1 comment · Fixed by #7919

Comments

@hffvld
Copy link
Collaborator

hffvld commented Aug 18, 2023

Description:

Reopen Last Closed Tab is shown when no recently closed tabs are there. Need to relaunch Brave to hide that option.

Steps to Reproduce

  1. Fresh launch Brave
  2. Tap and hold Tabs switch button >Tap View Recently Closed Tabs > Confirm there are no tabs shown > Done
  3. Open one tab > Now close that tab
  4. Tap and hold Tabs switch button again > Confirm that Reopen Last Closed Tab is shown now
  5. Tap View Recently Closed Tabs > Clear the list
  6. Tap and hold Tabs switch button > Observe that Reopen Last Closed Tab is still shown even when Recently Closed Tabs list is empty

Actual result:

Reopen Last Closed Tab is shown and it's possible to open a recently closed tab even when Recently Closed Tabs list is empty. This is true until you relaunch Brave.

Recently.closed.is.shown.mov

Expected result:

Reopen Last Closed Tab must not be shown when Recently Closed Tabs list is empty.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.57 (23.8.16.21)
BraveCore: 1.57.47 (116.0.5845.96)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 14 [iOS 16.6]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@hffvld
Copy link
Collaborator Author

hffvld commented Sep 26, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.58 (23.9.26.17)
BraveCore: 1.58.129 (117.0.5938.88)

STEPS:
Followed the steps from #7897 (comment)

ACTUAL RESULTS:

  • Verified that Reopen Last Closed Tab and View Recently Closed Tabs are not shown if no tabs were closed.
  • Verified that the user can use Reopen Last Closed Tab and View Recently Closed Tabs options when there is at least one recently closed tab.

1 2 3
1 2 3
2023-09-26_14-28-43.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants