Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Incorrect token and account shown in Buy screen and fails to load the on-ramp provider list #8103

Closed
srirambv opened this issue Sep 20, 2023 · 1 comment · Fixed by #8116
Closed

Incorrect token and account shown in Buy screen and fails to load the on-ramp provider list #8103

srirambv opened this issue Sep 20, 2023 · 1 comment · Fixed by #8116
Assignees
@StephenHeaps
Labels
bug Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.58

Comments

@srirambv
Copy link
Contributor

Description:

Incorrect token and account shown in Buy screen and fails to load the on-ramp provider list

Steps to Reproduce

  1. Upgrade to 1.58 (23.9.19.14)
  2. Open any ETH token and select Buy
  3. Shows Solana account but token details/network is correctly shown
  4. Click on Select purchase method
  5. No provider is shown
  6. Change token a few times and try again shows the providers list

Actual result:

Buy.Screen.bug.MP4

Expected result:

Should show the correct default account based on the token selection and should provide the list of providers for on-ramp purchase

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 13 (iOS 17)

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? na

Additional Information

cc: @StephenHeaps @nuo-xu
@StephenHeaps StephenHeaps self-assigned this Sep 20, 2023
@srirambv srirambv mentioned this issue Sep 21, 2023
Closed
@StephenHeaps StephenHeaps added this to the 1.58 milestone Sep 21, 2023
@StephenHeaps StephenHeaps mentioned this issue Sep 21, 2023
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Sep 21, 2023
@StephenHeaps
Fix #8115, #8103: Ensure selected account after Switch Chain request,…
6a9b03c 
… after opening Buy from Asset Detail (#8116)

Ensure selected account in `chainChangedEvent` to handle case where network switches internally in core, for example during a Switch Chain request.
StephenHeaps added a commit that referenced this issue Sep 21, 2023
@StephenHeaps
Fix #8115, #8103: Ensure selected account after Switch Chain request,…
046de65 
… after opening Buy from Asset Detail (#8116)

Ensure selected account in `chainChangedEvent` to handle case where network switches internally in core, for example during a Switch Chain request.
@srirambv
Copy link
Contributor Author

Verified as part of #8115 (comment)

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#8115, brave/brave-ios#8103: Ensure selected accou…
b0abac5 
…nt after Switch Chain request, after opening Buy from Asset Detail (brave/brave-ios#8116)

Ensure selected account in `chainChangedEvent` to handle case where network switches internally in core, for example during a Switch Chain request.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
bug Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.58
2 participants
@StephenHeaps @srirambv