This repository has been archived by the owner on May 10, 2024. It is now read-only.
Crash when opening the rewards panel the first time in a fresh install #8109
Assignees
Labels
Milestone
Comments
kylehickinson
added a commit
that referenced
this issue
Sep 20, 2023
Calling rewards engine APIs before the engine has been initialized can cause a crash because the `WhenReady` method used inside `RewardsEngineImpl` will queue up what is assumed a `SingleThreadedTaskRunner`. This is not the case for iOS which uses a standard sequenced task runner. This call to fetch promotions happens when showing the rewards panel but the rewards engine may not be initialized until the panel is shown (a sec/privacy requirement to not make API calls to rewards services until a user interacts with the feature), so it was being scheduled instead of executing immediately, thus hitting the threading issue on the brave-core side
11 tasks
kylehickinson
added a commit
that referenced
this issue
Sep 20, 2023
…ces (#8110) Calling rewards engine APIs before the engine has been initialized can cause a crash because the `WhenReady` method used inside `RewardsEngineImpl` will queue up what is assumed a `SingleThreadedTaskRunner`. This is not the case for iOS which uses a standard sequenced task runner. This call to fetch promotions happens when showing the rewards panel but the rewards engine may not be initialized until the panel is shown (a sec/privacy requirement to not make API calls to rewards services until a user interacts with the feature), so it was being scheduled instead of executing immediately, thus hitting the threading issue on the brave-core side
|
Verified on
|
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this issue
Feb 13, 2024
…d rewards services (brave/brave-ios#8110) Calling rewards engine APIs before the engine has been initialized can cause a crash because the `WhenReady` method used inside `RewardsEngineImpl` will queue up what is assumed a `SingleThreadedTaskRunner`. This is not the case for iOS which uses a standard sequenced task runner. This call to fetch promotions happens when showing the rewards panel but the rewards engine may not be initialized until the panel is shown (a sec/privacy requirement to not make API calls to rewards services until a user interacts with the feature), so it was being scheduled instead of executing immediately, thus hitting the threading issue on the brave-core side
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description:
In 1.59.x there is a crash when you open the rewards panel if it was never turned on in prior installations
Steps to Reproduce
The text was updated successfully, but these errors were encountered: