Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8056: Update P3A callout text. #8083

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix #8056: Update P3A callout text. #8083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Callout.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ extension BrowserViewController {
toggleTitle: Strings.Callout.p3aCalloutToggleTitle,
details: Strings.Callout.p3aCalloutDescription,
linkDescription: Strings.Callout.p3aCalloutLinkTitle,
primaryButtonTitle: Strings.done,
primaryButtonTitle: Strings.P3A.continueButton,
toggleAction: { [weak self] isOn in
self?.braveCore.p3aUtils.isP3AEnabled = isOn
},
Expand Down
5 changes: 5 additions & 0 deletions Sources/BraveStrings/BraveStrings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4576,6 +4576,11 @@ extension Strings {
"p3a.settingSubtitle", tableName: "BraveShared", bundle: .module,
value: "Anonymised P3A info helps Brave estimate overall usage and ensure we're improving popular features.",
comment: "A subtitle shown on the setting that toggles analytics on Brave.")

public static let continueButton = NSLocalizedString(
"p3a.continue", tableName: "BraveShared", bundle: .module,
value: "Continue",
comment: "A button to proceed with the rest of the user onboarding after they see the P3A introduction. It means to continue browsing or continue with the rest of the onboarding")
}
}

Expand Down
2 changes: 1 addition & 1 deletion Sources/Onboarding/Welcome/WelcomeViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ public class WelcomeViewController: UIViewController {
toggleTitle: Strings.Callout.p3aCalloutToggleTitle,
details: Strings.Callout.p3aCalloutDescription,
linkDescription: Strings.Callout.p3aCalloutLinkTitle,
primaryButtonTitle: Strings.done,
primaryButtonTitle: Strings.P3A.continueButton,
toggleAction: { [weak self] isOn in
self?.p3aUtilities.isP3AEnabled = isOn
},
Expand Down