Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[v1.60] Fix #8182: KeyringInfo Refactor, Bump BraveCore to v1.60.81 #8197

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

  • accountsInfo was removed from KeyringInfo. We must fetch accounts using GetAllAccounts api on Keyring Service now.

This pull request fixes #8182

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Test setting up new wallet & wallet restore
  2. Verify Ethereum & Solana accounts shown on Accounts tab
  3. Test creating a send transaction
  4. Verify Transaction Confirmation displays as expected (accounts shown in header)
  5. Verify transaction shows on Activity tab
  6. Verify accounts for token coin type shown in Asset Detail, transaction created in step 3 shows up
  7. Tap the transaction and verify transaction detail displays as expected

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps added this to the 1.60 milestone Oct 5, 2023
@StephenHeaps StephenHeaps requested a review from a team as a code owner October 5, 2023 13:56
@StephenHeaps StephenHeaps self-assigned this Oct 5, 2023
@StephenHeaps StephenHeaps linked an issue Oct 6, 2023 that may be closed by this pull request
@StephenHeaps StephenHeaps merged commit 584e115 into brave-core-1.60.x Oct 12, 2023
5 checks passed
@StephenHeaps StephenHeaps deleted the wallet/keyring-accountInfos-refactor branch October 12, 2023 19:25
nuo-xu pushed a commit that referenced this pull request Oct 13, 2023
…8197)

* Address changes for removing `accountInfos` array from `KeyringInfo`.

* Update BraveCore to v1.60.81
cuba pushed a commit that referenced this pull request Oct 17, 2023
…8197)

* Address changes for removing `accountInfos` array from `KeyringInfo`.

* Update BraveCore to v1.60.81
cuba pushed a commit that referenced this pull request Oct 18, 2023
…8197)

* Address changes for removing `accountInfos` array from `KeyringInfo`.

* Update BraveCore to v1.60.81
cuba pushed a commit that referenced this pull request Oct 18, 2023
…8197)

* Address changes for removing `accountInfos` array from `KeyringInfo`.

* Update BraveCore to v1.60.81
StephenHeaps added a commit that referenced this pull request Oct 20, 2023
…8197)

* Address changes for removing `accountInfos` array from `KeyringInfo`.

* Update BraveCore to v1.60.81
@iccub iccub modified the milestones: [old] 1.60, 1.60 Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyringInfo refactor
3 participants