Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8344: Update VPN text on the paywall #8356

Merged
merged 1 commit into from
Nov 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 38 additions & 27 deletions Sources/BraveStrings/BraveStrings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2626,44 +2626,35 @@ extension Strings {
comment: "It's like when there's few subscription plans, and one plan has the best value to price ratio, so this label says next to that plan: '(plan) - Best value'")

// MARK: Checkboxes
public static let checkboxBlockAds =
NSLocalizedString("vpn.checkboxBlockAds", tableName: "BraveShared", bundle: .module,
value: "Blocks unwanted network connections",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let checkboxBlockAdsAlternate =
NSLocalizedString("vpn.checkboxBlockAdsAlternate", tableName: "BraveShared", bundle: .module,
value: "Block ads & trackers across all apps ",
public static let checkboxProtectYourDevices =
NSLocalizedString("vpn.checkboxProtectYourDevices", tableName: "BraveShared", bundle: .module,
value: "Protect every app & your whole device",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let checkboxGeoSelector =
NSLocalizedString("vpn.checkboxGeoSelector", tableName: "BraveShared", bundle: .module,
value: "Choose your geo/country location",
public static let checkboxSaferWifi =
NSLocalizedString("vpn.checkboxSaferWifi", tableName: "BraveShared", bundle: .module,
value: "Safer for home or public Wi-Fi",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let checkboxFast =
NSLocalizedString("vpn.checkboxFast", tableName: "BraveShared", bundle: .module,
value: "Supports speeds of up to 100 Mbps",
public static let checkboxSpeedFast =
NSLocalizedString("vpn.checkboxSpeedFast", tableName: "BraveShared", bundle: .module,
value: "Lightning-fast, up to 100 Mbps",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let checkboxFastAlternate =
NSLocalizedString("vpn.checkboxFastAlternate", tableName: "BraveShared", bundle: .module,
value: "Fast and unlimited up to 100 Mbps",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let checkboxNoSellout =
NSLocalizedString("vpn.checkboxNoSellout", tableName: "BraveShared", bundle: .module,
value: "We never share or sell your info",
public static let checkboxGeoLocation =
NSLocalizedString("vpn.checkboxGeoLocation", tableName: "BraveShared", bundle: .module,
value: "Choose your geo/country location",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let checkboxNoIPLog =
NSLocalizedString("vpn.checkboxNoIPLog", tableName: "BraveShared", bundle: .module,
value: "Keeps you anonymous online",
value: "Brave never logs your activity",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let checkboxEncryption =
NSLocalizedString("vpn.checkboxEncryption", tableName: "BraveShared", bundle: .module,
value: "Uses secure encrypted VPN tunnels",
public static let checkboxDevicesProtect =
NSLocalizedString("vpn.checkboxDevicesProtect", tableName: "BraveShared", bundle: .module,
value: "Protect 5 devices on 1 subscription",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let installTitle =
Expand All @@ -2685,6 +2676,26 @@ extension Strings {
NSLocalizedString("vpn.popupCheckmark247Support", tableName: "BraveShared", bundle: .module,
value: "24/7 support",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let popupCheckboxBlockAds =
NSLocalizedString("vpn.popupCheckboxBlockAds", tableName: "BraveShared", bundle: .module,
value: "Blocks unwanted network connections",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let popupCheckboxBlockAdsAlternate =
NSLocalizedString("vpn.popupCheckboxBlockAdsAlternate", tableName: "BraveShared", bundle: .module,
value: "Block ads & trackers across all apps ",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let popupCheckboxFast =
NSLocalizedString("vpn.popupCheckboxFast", tableName: "BraveShared", bundle: .module,
value: "Supports speeds of up to 100 Mbps",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let popupCheckboxFastAlternate =
NSLocalizedString("vpn.popupCheckboxFastAlternate", tableName: "BraveShared", bundle: .module,
value: "Fast and unlimited up to 100 Mbps",
comment: "Text for a checkbox to present the user benefits for using Brave VPN")

public static let installProfileBody =
NSLocalizedString("vpn.installProfileBody", tableName: "BraveShared", bundle: .module,
Expand Down
10 changes: 5 additions & 5 deletions Sources/BraveVPN/BuyVPNView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ class BuyVPNView: UIView {

private let checkmarkViewStrings =
[
Strings.VPN.checkboxBlockAds,
Strings.VPN.checkboxGeoSelector,
Strings.VPN.checkboxProtectYourDevices,
Strings.VPN.checkboxSaferWifi,
Strings.VPN.checkboxSpeedFast,
Strings.VPN.checkboxGeoLocation,
Strings.VPN.checkboxNoIPLog,
Strings.VPN.checkboxFast,
Strings.VPN.checkboxEncryption,
Strings.VPN.checkboxNoSellout,
Strings.VPN.checkboxDevicesProtect,
]

private var checkmarksPage = 0 {
Expand Down
4 changes: 2 additions & 2 deletions Sources/Onboarding/Callouts/OnboardingVPNDetailsView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import BraveShared
public struct OnboardingVPNDetailsView: View {
public var learnMore: (() -> Void)?

private let descriptionItems = [Strings.VPN.checkboxBlockAds,
private let descriptionItems = [Strings.VPN.popupCheckboxBlockAds,
Strings.VPN.popupCheckmarkSecureConnections,
Strings.VPN.checkboxFast,
Strings.VPN.popupCheckboxFast,
Strings.VPN.popupCheckmark247Support]

public init() {}
Expand Down
4 changes: 2 additions & 2 deletions Sources/Onboarding/VPNNotifications/VPNChurnPromoView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ public struct VPNChurnPromoView: View {

public var churnPromoType: VPNChurnPromoType

private let descriptionItems = [Strings.VPN.checkboxBlockAdsAlternate,
private let descriptionItems = [Strings.VPN.popupCheckboxBlockAdsAlternate,
Strings.VPN.popupCheckmarkSecureConnections,
Strings.VPN.checkboxFastAlternate,
Strings.VPN.popupCheckboxFastAlternate,
Strings.VPN.popupCheckmark247Support]

public init(churnPromoType: VPNChurnPromoType) {
Expand Down