Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8721: Approve transaction does not show confirmation after editing allowance #8725

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix #8721: Approve transaction does not show confirmation after editing allowance #8725

merged 2 commits into from
Feb 1, 2024

Commits on Feb 1, 2024

  1. Fix case where TransactionConfirmationStore is torn down from obser… 

    …vation when opening a detail view to edit approve tx permissions, which can cause spinner to show until transaction confirmation modal is dismissed because we miss the transaction updated observation method callback.
    @StephenHeaps
    StephenHeaps committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a722540 View commit details
    Browse the repository at this point in the history

  2. Close stores on dismiss of modal to cover case where user manually di… 

    …smisses modal RequestContainerView
    @StephenHeaps
    StephenHeaps committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    34053da View commit details
    Browse the repository at this point in the history