Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8768: Add Logging to Track Secure Content State #8769

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

soner-yuksel
Copy link
Contributor

Summary of Changes

Customizing the Logger and adding secure state logging

This pull request fixes brave/brave-browser#36281

This Pr will be also opened in brave-core side

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Run the application
  • Go .. dot menu and settings
  • Find Secure Content Debug at the bottom
  • Check the logs or share

Screenshots:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-21.at.13.25.13.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel self-assigned this Feb 21, 2024
@soner-yuksel soner-yuksel requested a review from a team as a code owner February 21, 2024 18:26
@soner-yuksel soner-yuksel added this to the icebox milestone Feb 27, 2024
@soner-yuksel soner-yuksel merged commit f41582f into development Feb 27, 2024
12 checks passed
@soner-yuksel soner-yuksel deleted the enhancement/log-state-secure branch February 27, 2024 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Logging to Track Secure Content State
2 participants