perf: stop auto-generating shiled() in dev

brillout · Oct 10, 2022 · 32a3008 · 32a3008
1 parent 9ba3fb9
commit 32a3008
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 8 deletions.
diff --git a/examples/vite/.testRun.ts b/examples/vite/.testRun.ts
@@ -12,6 +12,13 @@ function testRun(
     run(cmd, { serverIsReadyMessage })
   }
 
+  {
+    const isDev = cmd !== 'npm run preview'
+    if (isDev) {
+      skipShieldGenerationTest = true
+    }
+  }
+
   test('example', async () => {
     {
       const html = await fetchHtml('/')

diff --git a/telefunc/node/server/runTelefunc/applyShield.ts b/telefunc/node/server/runTelefunc/applyShield.ts
@@ -9,15 +9,18 @@ function applyShield(runContext: {
   telefunctionName: string
   telefunctionArgs: unknown[]
   logInvalidRequests: boolean
+  isProduction: boolean
 }): { isValidRequest: boolean } {
   const { telefunction } = runContext
 
   const hasShield = !shieldIsMissing(telefunction)
-  assertWarning(
-    hasShield || telefunction.length === 0,
-    `The telefunction ${runContext.telefunctionName} accepts arguments yet is missing \`shield()\`, see https://telefunc.com/shield`,
-    { onlyOnce: true }
-  )
+  if (runContext.isProduction) {
+    assertWarning(
+      hasShield || telefunction.length === 0,
+      `The telefunction ${runContext.telefunctionName} accepts arguments yet is missing \`shield()\`, see https://telefunc.com/shield`,
+      { onlyOnce: true }
+    )
+  }
   if (!hasShield) {
     return { isValidRequest: true }
   }

diff --git a/telefunc/node/vite/transform.ts b/telefunc/node/vite/transform.ts
@@ -8,13 +8,17 @@ export { transform }
 
 function transform(): Plugin {
   let root: string
+  let isDev: boolean = false
   return {
     name: 'telefunc:transform',
     enforce: 'pre',
     configResolved: (config) => {
       root = toPosixPath(config.root)
       assert(root)
     },
+    configureServer() {
+      isDev = true
+    },
     async transform(code, id, options) {
       if (!id.includes('.telefunc.')) {
         return
@@ -25,9 +29,11 @@ function transform(): Plugin {
       if (isClientSide) {
         code = await transformTelefuncFileClientSide(code, id, root)
       } else {
-        code = (await transformTelefuncFileServerSide(code, id, root, true))
-        if (id.endsWith('.ts')) {
-          code = generateShield(code)
+        code = await transformTelefuncFileServerSide(code, id, root, true)
+        if (!isDev) {
+          if (id.endsWith('.ts')) {
+            code = generateShield(code)
+          }
         }
       }