Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: blowfish support #380

Merged
merged 2 commits into from
Sep 16, 2021
Merged

feat: blowfish support #380

merged 2 commits into from
Sep 16, 2021

Conversation

Alanscut
Copy link
Contributor

issue:#76

Copy link
Member

@evanvosberg evanvosberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Just one thing, see the comment for.

src/blowfish.js Outdated
* var ciphertext = CryptoJS.BF.encrypt(message, key, cfg);
* var plaintext = CryptoJS.BF.decrypt(ciphertext, key, cfg);
*/
C.BF = BlockCipher._createHelper(BF);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to name it C.Blowfish instead of using abbreviation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, Done!

@evanvosberg evanvosberg merged commit 4dcaa7a into brix:develop Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants